Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix quirks in URL field in view editor #21410

Merged
merged 1 commit into from
Jul 19, 2024

Conversation

karwosts
Copy link
Contributor

@karwosts karwosts commented Jul 16, 2024

Proposed change

Fix 2 bugs in the URL field of view editor:

  • When user deletes the URL field, it would be instantly replaced with the slugified title. Should be left empty.
  • When URL matches the title, and title is backspaced to empty, we would leave one letter in the URL field. Should be reset to empty as well.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

Summary by CodeRabbit

  • Bug Fixes
    • Improved logic for setting the config.path property in the view editor, ensuring path is correctly generated even if the title is missing.

This comment was marked as off-topic.

coderabbitai[bot]

This comment was marked as off-topic.

@bramkragten bramkragten merged commit 8cb63ac into home-assistant:dev Jul 19, 2024
14 checks passed
@karwosts karwosts deleted the fix-view-editor-path branch July 19, 2024 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

URL field of View rejects input
2 participants